Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: marker event was only triggered for first and last visible section items #14124

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Android: marker event was only triggered for first and last visible section items #14124

merged 2 commits into from
Sep 27, 2024

Conversation

prashantsaini1
Copy link
Contributor

Issue: ListView marker event was triggered only for first and last visible section items.

Fix:

  • It will be now triggered for all visible items (from whatever sections they belong to), starting from the first visible item till the last visible item.
  • It also brings parity with iOS marker event as it's triggered in same way.

@hansemannn hansemannn merged commit fb696a1 into tidev:master Sep 27, 2024
4 of 5 checks passed
hansemannn pushed a commit that referenced this pull request Sep 27, 2024
@prashantsaini1 @hansemannn
Android: marker event was only triggered for first and last visible s…
edc6163 
…ection items (#14124)

* fix(android): fire marker event for all visible items in range of first to last visible item

* chore: remove package.json files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashantsaini1 @hansemannn